Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup busybox rootfs #35

Merged
merged 5 commits into from
Jul 13, 2024
Merged

Setup busybox rootfs #35

merged 5 commits into from
Jul 13, 2024

Conversation

eureka-cpu
Copy link
Contributor

@eureka-cpu eureka-cpu commented Jul 11, 2024

Ref #34

Create the busybox filesystem for running lasr programs.

Pre-pulls the busybox image from dockerhub, streaming the image to stdout and loading it into the docker registry. This speeds up the node-start pre-script by having the image ready beforehand when building the container to create the rootfs.

@eureka-cpu eureka-cpu added the bug Something isn't working label Jul 11, 2024
@eureka-cpu eureka-cpu added this to the LASR beta-devnet milestone Jul 11, 2024
@eureka-cpu eureka-cpu self-assigned this Jul 11, 2024
@eureka-cpu
Copy link
Contributor Author

eureka-cpu commented Jul 11, 2024

So far this does the trick but not in the nix-way per se. It could be better but feel free to approve/merge once CI passes, and please check it out for yourself!

Copy link
Contributor

@andrewvious andrewvious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested locally, the busybox rootfs dir is created and populated, however we are still getting the batcher error. Might require some fine tuning to get the payload dir working properly. Nice job! Nix 🤝 Docker

@eureka-cpu
Copy link
Contributor Author

I've tested locally, the busybox rootfs dir is created and populated, however we are still getting the batcher error. Might require some fine tuning to get the payload dir working properly. Nice job! Nix 🤝 Docker

I know you've had some trouble with nix/docker interop in the past, but man. Nix really makes working with docker easy.

@eureka-cpu eureka-cpu merged commit 7d6bb93 into master Jul 13, 2024
4 checks passed
@eureka-cpu eureka-cpu deleted the eureka-cpu/34 branch July 13, 2024 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants