Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Closes #290, implemented request body stream reading for PutObj… #296

Closed
wants to merge 1 commit into from

Conversation

0x180
Copy link
Contributor

@0x180 0x180 commented Nov 15, 2023

Implemented request body streaming for PutObject and UploadPart actions

@@ -181,6 +187,7 @@
}
calculatedSign := strings.Split(parts[3], "=")[1]
expectedSign := strings.Split(authParts[2], "=")[1]
fmt.Println(calculatedSign, expectedSign)

Check failure

Code scanning / CodeQL

Clear-text logging of sensitive information

[Sensitive data returned by HTTP request headers](1) flows to a logging call.
@benmcclelland benmcclelland marked this pull request as draft November 29, 2023 16:29
@benmcclelland
Copy link
Member

closing this, and contiuing work in #331

@benmcclelland benmcclelland deleted the req-body-streaming branch December 13, 2023 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants