S3 proxy ListParts max parts issue #338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s3api/controllers/base.go
Outdated
| @@ -92,7 +92,7 @@ func (c S3ApiController) GetActions(ctx *fiber.Ctx) error { | |||
| } | |||
|
|
|||
| if uploadId != "" { | |||
| if maxParts < 0 || (maxParts == 0 && ctx.Query("max-parts") != "") { | |||
| if (maxParts < 0 && ctx.Request().URI().QueryArgs().Has("max-parts")) || maxParts > 2147483647 { | |||
There was a problem hiding this comment.
better to use math.MaxInt32 instead of 2147483647 so its clear where this number comes from
There was a problem hiding this comment.
I removed this check: it's unnecessary. If max-parts is larger than math.MaxInt32 it will result the variable value to be -1 and it will return the error
benmcclelland
approved these changes
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed max-parts property issue in ListParts action to pass nil if the property is not provided
Added .vscode in gitignore(didn't want to create another PR for this)