Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

S3 Proxy DeleteObjects empty input #340

Merged
merged 6 commits into from
Dec 14, 2023
Merged

S3 Proxy DeleteObjects empty input #340

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
05ccdf3
feat: implemented the logic to run integration tests separately
0x180 Dec 11, 2023
950f30e
Merge branch 'int-tests-by-unit' of https://github.com/versity/versitygw
0x180 Dec 12, 2023
973a03c
git checkoutMerge branch 'main' of https://github.com/versity/versitygw
0x180 Dec 12, 2023
444ea87
Merge branch 'main' of https://github.com/versity/versitygw
0x180 Dec 13, 2023
c392a4f
Merge branch 'main' of https://github.com/versity/versitygw
0x180 Dec 14, 2023
37c1026
fix: Fixes #335, fixed s3 proxy DeleteObject empty input bug
0x180 Dec 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions backend/s3proxy/s3.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -409,6 +409,10 @@ func (s *S3be) DeleteObjects(ctx context.Context, input *s3.DeleteObjectsInput)
return s3response.DeleteObjectsResult{}, err
}

if len(input.Delete.Objects) == 0 {
input.Delete.Objects = []types.ObjectIdentifier{}
}

output, err := client.DeleteObjects(ctx, input)
err = handleError(err)
if err != nil {
Expand Down