Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: list objects trim common prefixes that match marker prefix #806

Merged
merged 2 commits into from
Sep 18, 2024

Conversation

benmcclelland
Copy link
Member

This checks to see if the common prefix is before the marker and thus would have been returned in earlier list objects request.

The error case was aws cli listing multiple entries for the same common prefix when the listing required multiple pagination requests.

Fixes #778

@benmcclelland benmcclelland force-pushed the ben/common_prefixes branch 2 times, most recently from bf754f4 to e497434 Compare September 13, 2024 22:50
@benmcclelland benmcclelland requested a review from 0x180 September 13, 2024 22:51
Copy link
Contributor

@0x180 0x180 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add an integration test case for paginated common prefixes ?

Could you make sure azure also handles this case correctly and passes the tests?

@benmcclelland benmcclelland force-pushed the ben/common_prefixes branch 2 times, most recently from b16192d to 8b8c00b Compare September 18, 2024 04:37

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
This checks to see if the common prefix is before the marker and
thus would have been returned in earlier list objects request.

The error case was aws cli listing multiple entries for the same
common prefix when the listing required multiple pagination
requests.

Fixes #778
@benmcclelland benmcclelland merged commit cf067b5 into main Sep 18, 2024
17 checks passed
@benmcclelland benmcclelland deleted the ben/common_prefixes branch September 18, 2024 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

s3 ls --page-size can return duplicate output
2 participants