Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

null versionId objects #886

Merged
merged 1 commit into from
Oct 11, 2024
Merged

null versionId objects #886

merged 1 commit into from
Oct 11, 2024

Conversation

0x180
Copy link
Contributor

@0x180 0x180 commented Oct 11, 2024

The implementation handles put/get/delete operations for null versionId objects. If versionId attribute isn't set for an object, it's treated as null.

It ensures that there is always exactly one object version with null versionId in a bucket at any given time.

The file name for the object with a null versionId is null in the versioning directory.

The listing of object versions follows this strategy:

  1. Locate the object with the null versionId first.
  2. Begin listing the other object versions.
  3. Insert the null versionId object into its correct position in the list by comparing modification dates to maintain the proper order.

Fixes #864

… enabled buckets within the versioning directory
@benmcclelland benmcclelland merged commit 79ece46 into main Oct 11, 2024
20 checks passed
@benmcclelland benmcclelland deleted the fix/versioning-null-versionid branch October 11, 2024 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] - null VersionId is incorrectly updated after versioning is enabled and key is updated
2 participants