test: REST multipart upload testing, cleanup #898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lrm25
force-pushed
the
test_cmdline_lock_versioning
branch
from
3803cc0 to
8f54b93
Compare
lrm25
changed the title
anodelman
reviewed
Oct 17, 2024
|
|
||
| # Step 3: generate signature | ||
|
|
||
| date_key=$(echo -n "$year_month_day" | openssl dgst -sha256 -mac HMAC -macopt key:"AWS4${aws_secret_access_key}" | awk '{print $2}') |
There was a problem hiding this comment.
This should get wrapped in a function somewhere since the same code is used in another test file.
lrm25
force-pushed
the
test_cmdline_lock_versioning
branch
2 times, most recently
from
6334d2a to
c4825b3
Compare
anodelman
requested changes
Oct 21, 2024
tests/test_common_acl.sh
Outdated
| test_put_bucket_acl_s3cmd() { | ||
| if [[ $DIRECT != "true" ]]; then | ||
| # https://github.com/versity/versitygw/issues/695 | ||
| skip |
There was a problem hiding this comment.
Can you add a skip message here to appear in the logs please.
tests/test_common_acl.sh
Outdated
| test_common_put_bucket_acl() { | ||
| if [[ $RECREATE_BUCKETS == "false" ]]; then | ||
| # https://github.com/versity/versitygw/issues/716 | ||
| skip |
lrm25
force-pushed
the
test_cmdline_lock_versioning
branch
from
c4825b3 to
e291f6a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.