test: REST multipart upload listing, completion #912
Conversation
lrm25
force-pushed
the
test_cmdline_list_parts_three
branch
2 times, most recently
from
d57f10a to
11a5e3f
Compare
tests/util_bucket.sh
Outdated
|
|
||
| # params: client, bucket name | ||
| # return 0 for success, 1 for error | ||
| delete_bucket_or_contents() { |
There was a problem hiding this comment.
I'm a little confused as to this method - why isn't it two methods? One for deleting only bucket contents and one for deleting the bucket itself? Considering that it is mainly just a wrapper with an variable check it just seems weird to me.
There was a problem hiding this comment.
It was just to combine operations for static and non-static bucket cleanup. For both, occasionally you need to delete individual objects due to WORM protection. And just to avoid putting the static check in each test. If you think there's a better way to do it though, let me know.
There was a problem hiding this comment.
Could maybe just use different naming to be clearer what is going on - bucket_cleanup? bucket_cleanup_worm_compliant? And then add a comment to each section explaining why there's different operations for static/non-static.
tests/util_bucket.sh
Outdated
|
|
||
| # params: client, bucket name | ||
| # return 0 for success, 1 for error | ||
| delete_bucket_or_contents_if_exists() { |
There was a problem hiding this comment.
Same question here? Seems like the 'or' clause belongs a level higher in the code and not in a method name.
lrm25
force-pushed
the
test_cmdline_list_parts_three
branch
from
11a5e3f to
f9b2cf4
Compare
lrm25
force-pushed
the
test_cmdline_list_parts_three
branch
from
f9b2cf4 to
bf4fc71
Compare
No description provided.