Test/rest put acl canned #985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lrm25
force-pushed
the
test/rest_put_acl_canned
branch
2 times, most recently
from
c1508fa to
945ddbf
Compare
anodelman
requested changes
Dec 12, 2024
tests/rest_scripts/put_bucket_acl.sh
Outdated
| -o "$OUTPUT_FILE") | ||
| curl_command+=(curl -ks -w "\"%{http_code}\"" -X PUT "$AWS_ENDPOINT_URL/$bucket_name?acl=") | ||
| if [ -n "$CANNED_ACL" ]; then | ||
| curl_command+=(-H "\"Authorization: AWS4-HMAC-SHA256 Credential=$aws_access_key_id/$year_month_day/$aws_region/s3/aws4_request,SignedHeaders=host;x-amz-acl;x-amz-content-sha256;x-amz-date,Signature=$signature\"") |
There was a problem hiding this comment.
There's a big chunk of shared string here between this and the next section of the if/else. Can stick in a var and then just add on the different bit.
lrm25
force-pushed
the
test/rest_put_acl_canned
branch
from
675792f to
10decc0
Compare
anodelman
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.