Issues/#218 parentheses in display name #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To ensure that the new code solves bug vert-x3#218 while still allowing comments in the local part of the email to count as a valid email address.
This fixes isse vert-x3#218, though there are still edge cases for valid emails which won't be allowed (such as those with comments) or invalid emails which will still be allowed (eg. this"is"[email protected]). The best choice for accuracy would be to add a parser, but this could slow down runtime. It may not be a worthy sacrifice.
gaol
approved these changes
Oct 29, 2024
|
LGTM! |
|
@tararoshan thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
This addresses issue #218 where emails with display names in parentheses are not sent.
Conformance:
I have signed the Eclipse Contributor Agreement and noted that this is my GitHub account (tararoshan).
Thanks!