Skip to content

Commit

Permalink
fix: use fully qualified image names (#148)
Browse files Browse the repository at this point in the history
Using an unqualified image name might yield different results on
different systems. The deployment actually relies on docker's default,
which is 'docker.io'. Other system might not have this default, and
some systems might even pause and interactively ask the user for a
decision.

Providing a fully qualified image name solves this issues and ensures
that the intended image is pulled.
  • Loading branch information
ctron authored Jul 12, 2023
1 parent 96f0b77 commit 7b916e6
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 13 deletions.
6 changes: 3 additions & 3 deletions docker-compose-lite.yaml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
version: '3.4'
services:
metad0:
image: vesoft/nebula-metad:nightly
image: docker.io/vesoft/nebula-metad:nightly
environment:
USER: root
command:
Expand Down Expand Up @@ -34,7 +34,7 @@ services:
- SYS_PTRACE

storaged0:
image: vesoft/nebula-storaged:nightly
image: docker.io/vesoft/nebula-storaged:nightly
environment:
USER: root
TZ: "${TZ}"
Expand Down Expand Up @@ -70,7 +70,7 @@ services:
- SYS_PTRACE

graphd:
image: vesoft/nebula-graphd:nightly
image: docker.io/vesoft/nebula-graphd:nightly
environment:
USER: root
TZ: "${TZ}"
Expand Down
20 changes: 10 additions & 10 deletions docker-compose.yaml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
version: '3.4'
services:
metad0:
image: vesoft/nebula-metad:nightly
image: docker.io/vesoft/nebula-metad:nightly
environment:
USER: root
TZ: "${TZ}"
Expand Down Expand Up @@ -35,7 +35,7 @@ services:
- SYS_PTRACE

metad1:
image: vesoft/nebula-metad:nightly
image: docker.io/vesoft/nebula-metad:nightly
environment:
USER: root
TZ: "${TZ}"
Expand Down Expand Up @@ -69,7 +69,7 @@ services:
- SYS_PTRACE

metad2:
image: vesoft/nebula-metad:nightly
image: docker.io/vesoft/nebula-metad:nightly
environment:
USER: root
TZ: "${TZ}"
Expand Down Expand Up @@ -103,7 +103,7 @@ services:
- SYS_PTRACE

storaged0:
image: vesoft/nebula-storaged:nightly
image: docker.io/vesoft/nebula-storaged:nightly
environment:
USER: root
TZ: "${TZ}"
Expand Down Expand Up @@ -141,7 +141,7 @@ services:
- SYS_PTRACE

storaged1:
image: vesoft/nebula-storaged:nightly
image: docker.io/vesoft/nebula-storaged:nightly
environment:
USER: root
TZ: "${TZ}"
Expand Down Expand Up @@ -179,7 +179,7 @@ services:
- SYS_PTRACE

storaged2:
image: vesoft/nebula-storaged:nightly
image: docker.io/vesoft/nebula-storaged:nightly
environment:
USER: root
TZ: "${TZ}"
Expand Down Expand Up @@ -217,7 +217,7 @@ services:
- SYS_PTRACE

graphd:
image: vesoft/nebula-graphd:nightly
image: docker.io/vesoft/nebula-graphd:nightly
environment:
USER: root
TZ: "${TZ}"
Expand Down Expand Up @@ -253,7 +253,7 @@ services:
- SYS_PTRACE

graphd1:
image: vesoft/nebula-graphd:nightly
image: docker.io/vesoft/nebula-graphd:nightly
environment:
USER: root
TZ: "${TZ}"
Expand Down Expand Up @@ -289,7 +289,7 @@ services:
- SYS_PTRACE

graphd2:
image: vesoft/nebula-graphd:nightly
image: docker.io/vesoft/nebula-graphd:nightly
environment:
USER: root
TZ: "${TZ}"
Expand Down Expand Up @@ -325,7 +325,7 @@ services:
- SYS_PTRACE

console:
image: vesoft/nebula-console:nightly
image: docker.io/vesoft/nebula-console:nightly
entrypoint: ""
command:
- sh
Expand Down

0 comments on commit 7b916e6

Please sign in to comment.