Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split SSL example to separate directory #297

Merged
merged 2 commits into from
Jan 5, 2024

Conversation

haoxins
Copy link
Collaborator

@haoxins haoxins commented Dec 18, 2023

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Description:

This will clear the redeclaration errors in the examples.

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

@codecov-commenter
Copy link

codecov-commenter commented Dec 18, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a1e9598) 63.41% compared to head (48c3b68) 63.41%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #297   +/-   ##
=======================================
  Coverage   63.41%   63.41%           
=======================================
  Files           8        8           
  Lines        2392     2392           
=======================================
  Hits         1517     1517           
  Misses        750      750           
  Partials      125      125           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wey-gu wey-gu requested a review from veezhang December 18, 2023 09:58
@haoxins
Copy link
Collaborator Author

haoxins commented Dec 18, 2023

After this PR is merged, I will raise another PR for the draft implementation of the ResultSet.Scan method.

#296

@Nicole00 Nicole00 merged commit 488a3c4 into vesoft-inc:master Jan 5, 2024
20 checks passed
@haoxins haoxins deleted the split-exmples branch January 5, 2024 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants