Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix for issue 22 - placeholder breaks on mobile #24

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Bugfix for issue 22 - placeholder breaks on mobile #24

wants to merge 1 commit into from

Conversation

grwgreg
Copy link

@grwgreg grwgreg commented Dec 1, 2014

I had to change a few things to get this working.

The click event was being fired for the native select menu on both the initial opening of the select menu and also when an option was selected. This would call the triggerSod method, which didn't handle the toggling of the placeholder for touch devices. So I added some conditional checks for whether the select was being opened or closed on a touch device, toggling a new data variable $sod.data('touch_open') instead of the "open" class (which we don't want added on mobile devices).

Also, the blurSod method would then reset the placeholder to the wrong value on blur, based on which .sod_option had the selected class. To fix this I added some code to the selectChange method, setting the "selected" class on the right .sod_option element even though it isn't visible for mobile devices.

This seemed to fix it! 👯

Also updated the version number, date & reminified the file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant