feat: add full Rook support #1391
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
not a review of the code, but yay. I would like this option to be available until I feel like I trust it a bit more than cephadm :) |
fitbeard
force-pushed
the
feat/full_rook
branch
11 times, most recently
from
75e7816
to
f6283b4
Compare
|
@mnaser this change is ready for initial review. I just temporarily disabled other AIO tests to not waste resources. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change introduces full Rook support also preserving old functionality. This means that without setting
atmosphere_rook_ceph_enabled: trueeverything should be like before - ceph with cephadm and "thin" Rook inopenstacknamespace for RadosGateway only. There are few places with code dublication also to preserve maximal original functionality. Before starting writing Molecule tests I need your opinion Yay or Nay:)btw: tested on real hw.