Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional kubeconfig path to roles #1871

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

austintalbot
Copy link

No description provided.

@fitbeard
Copy link
Contributor

I see potential here for the future if we need access to remote clusters. For example for multi region "infrastructure" deployment.

Copy link
Member

@mnaser mnaser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small revision!

roles/barbican/tasks/main.yml Outdated Show resolved Hide resolved
@austintalbot austintalbot force-pushed the feature/add-optional-kubeconfig-path branch from cf06f20 to 723adc5 Compare September 11, 2024 15:23
fix vexxhost#1838

# Please enter the commit message for your changes. Lines starting
# with '#' will be ignored, and an empty message aborts the commit.
#
# Author:    Oleksandr K <[email protected]>
# Date:      Wed Sep 4 21:04:03 2024 +0200
#
# On branch feature/add-optional-kubeconfig-path
# Your branch is behind 'origin/feature/add-optional-kubeconfig-path' by 1 commit, and can be fast-forwarded.
#   (use "git pull" to update your local branch)
#
# Changes to be committed:
#	modified:   .gitignore
#	modified:   roles/barbican/defaults/main.yml
#	modified:   roles/barbican/tasks/main.yml
#	modified:   roles/ceph_csi_rbd/defaults/main.yml
#	modified:   roles/ceph_csi_rbd/tasks/main.yml
#	modified:   roles/ceph_provisioners/defaults/main.yml
#	modified:   roles/ceph_provisioners/tasks/main.yml
#	modified:   roles/cinder/defaults/main.yml
#	modified:   roles/cinder/tasks/main.yml
#	modified:   roles/cluster_issuer/defaults/main.yml
#	modified:   roles/coredns/defaults/main.yml
#	modified:   roles/coredns/tasks/main.yml
#	modified:   roles/designate/defaults/main.yml
#	modified:   roles/designate/tasks/main.yml
#	modified:   roles/glance/defaults/main.yml
#	modified:   roles/glance/tasks/main.yml
#	modified:   roles/goldpinger/defaults/main.yml
#	modified:   roles/goldpinger/tasks/main.yml
#	modified:   roles/heat/defaults/main.yml
#	modified:   roles/heat/tasks/main.yml
#	modified:   roles/horizon/defaults/main.yml
#	modified:   roles/horizon/tasks/main.yml
#	modified:   roles/ingress_nginx/defaults/main.yml
#	modified:   roles/ingress_nginx/tasks/main.yml
#	modified:   roles/ironic/defaults/main.yml
#	modified:   roles/ironic/tasks/main.yml
#	modified:   roles/keycloak/defaults/main.yml
#	modified:   roles/keycloak/tasks/main.yml
#	modified:   roles/keystone/defaults/main.yml
#	modified:   roles/keystone/tasks/main.yml
#	modified:   roles/kube_prometheus_stack/defaults/main.yml
#	modified:   roles/kube_prometheus_stack/tasks/main.yml
#	modified:   roles/libvirt/defaults/main.yml
#	modified:   roles/libvirt/tasks/main.yml
#	modified:   roles/local_path_provisioner/defaults/main.yml
#	modified:   roles/local_path_provisioner/tasks/main.yml
#	modified:   roles/loki/defaults/main.yml
#	modified:   roles/loki/tasks/main.yml
#	modified:   roles/magnum/defaults/main.yml
#	modified:   roles/magnum/tasks/main.yml
#	modified:   roles/manila/defaults/main.yml
#	modified:   roles/manila/tasks/main.yml
#	modified:   roles/memcached/defaults/main.yml
#	modified:   roles/memcached/tasks/main.yml
#	modified:   roles/neutron/defaults/main.yml
#	modified:   roles/neutron/tasks/main.yml
#	modified:   roles/node_feature_discovery/defaults/main.yml
#	modified:   roles/node_feature_discovery/tasks/main.yml
#	modified:   roles/nova/defaults/main.yml
#	modified:   roles/nova/tasks/main.yml
#	modified:   roles/octavia/defaults/main.yml
#	modified:   roles/octavia/tasks/main.yml
#	modified:   roles/openvswitch/defaults/main.yml
#	modified:   roles/openvswitch/tasks/main.yml
#	modified:   roles/ovn/defaults/main.yml
#	modified:   roles/ovn/tasks/main.yml
#	modified:   roles/percona_xtradb_cluster/vars/main.yml
#	modified:   roles/percona_xtradb_cluster_operator/defaults/main.yml
#	modified:   roles/percona_xtradb_cluster_operator/tasks/main.yml
#	modified:   roles/placement/defaults/main.yml
#	modified:   roles/placement/tasks/main.yml
#	new file:   roles/powerstore_csi/defaults/main.yaml
#	modified:   roles/powerstore_csi/tasks/main.yml
#	modified:   roles/prometheus_pushgateway/defaults/main.yml
#	modified:   roles/prometheus_pushgateway/tasks/main.yml
#	modified:   roles/rabbitmq_cluster_operator/defaults/main.yml
#	modified:   roles/rabbitmq_cluster_operator/tasks/main.yml
#	modified:   roles/rook_ceph/defaults/main.yml
#	modified:   roles/rook_ceph/tasks/main.yml
#	modified:   roles/rook_ceph_cluster/defaults/main.yml
#	modified:   roles/rook_ceph_cluster/tasks/main.yml
#	modified:   roles/staffeln/defaults/main.yaml
#	modified:   roles/staffeln/tasks/main.yaml
#	modified:   roles/tempest/defaults/main.yml
#	modified:   roles/tempest/tasks/main.yml
#	modified:   roles/vector/defaults/main.yml
#	modified:   roles/vector/tasks/main.yml
#
# Untracked files:
#	build/release.sh
#	doc/source/admin/ceph.rst
#	roles/cluster_issuer/tasks/type/acme/solver/azuredns.yml
#
@austintalbot austintalbot force-pushed the feature/add-optional-kubeconfig-path branch from 723adc5 to 10ae738 Compare September 11, 2024 15:27
@mnaser
Copy link
Member

mnaser commented Sep 11, 2024

recheck

Copy link
Member

@mnaser mnaser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small nit!

roles/coredns/tasks/main.yml Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants