Adding support to HeartBeat Monitor type

[rogerioefonseca]

• Add support to heartbeat
• Update documentation
• Refactor to reduce number of lines
• test the new monitor type

close #14

[rogerioefonseca]

@mnaser PTAL on this new MR.
I was working in a fork from louy repository and that one was some commits behind yours, now, I forked yours and created a new MR based on this.
And then the conflicts were gone

[mnaser]

one tiny nit but the refactor looks great.

[mnaser]

I think this was accidentally swallowed in the refactor :)

[rogerioefonseca]

Yep, you are right, thanks for the review.
Fixed - 8452343

[mnaser]

It looks like the tests failed, could you perhaps try and run them locally and see if you can reproduce and fix this?

I appreciate your follow up on this!

[rogerioefonseca]

It looks like the tests failed, could you perhaps try and run them locally and see if you can reproduce and fix this?

I appreciate your follow up on this!

I'll do it later today.

[rogerioefonseca]

It looks like the tests failed, could you perhaps try and run them locally and see if you can reproduce and fix this?
I appreciate your follow up on this!

I'll do it later today.

Done 9b5e31c

[rogerioefonseca]

It looks like the tests failed, could you perhaps try and run them locally and see if you can reproduce and fix this?
I appreciate your follow up on this!

I'll do it later today.

It was super late, and I misread the test outputs, now that I saw your commit I realized the tests problems.
But nice that you figure those and applied to master. I rebased and added your commits to this MR, so probably the tests will run without errors.

BTW, is there a special reason for the tests do not run right after the pull request is created?
I saw in the workflow that the tests are limited to be executed based on a cron definition...

[mnaser]

BTW, is there a special reason for the tests do not run right after the pull request is created?
I saw in the workflow that the tests are limited to be executed based on a cron definition...

It's a GitHub thing since you have not had any contributions yet.

https://docs.github.com/en/actions/managing-workflow-runs/approving-workflow-runs-from-public-forks

[rogerioefonseca]

BTW, is there a special reason for the tests do not run right after the pull request is created?
I saw in the workflow that the tests are limited to be executed based on a cron definition...

It's a GitHub thing since you have not had any contributions yet.

https://docs.github.com/en/actions/managing-workflow-runs/approving-workflow-runs-from-public-forks

Looks like it needs to add the TF and API KEY env variables into the Repo configuration, for some reason that I do not know looks like those are not being loaded into this one.

Will you have time to TAL on this?
Let me know if I can help somehow.

[rogerioefonseca]

BTW, is there a special reason for the tests do not run right after the pull request is created?

I saw in the workflow that the tests are limited to be executed based on a cron definition...

It's a GitHub thing since you have not had any contributions yet.

https://docs.github.com/en/actions/managing-workflow-runs/approving-workflow-runs-from-public-forks

Looks like it needs to add the TF and API KEY env variables into the Repo configuration, for some reason that I do not know looks like those are not being loaded into this one.

Will you have time to TAL on this?

Let me know if I can help somehow.

Ping...
🙂

[FlxPeters]

Any progress here? Would like to use this feature too and this seams to be the best maintained fork of the original repo.
Let me know if i can help bring this to an successful merge.

[rogerioefonseca]

Any progress here? Would like to use this feature too and this seams to be the best maintained fork of the original repo.

Let me know if i can help bring this to an successful merge.

@mnaser ....

[rogerioefonseca]

Any progress here? Would like to use this feature too and this seams to be the best maintained fork of the original repo.

Let me know if i can help bring this to an successful merge.

Not sure what else can I do as well.
@mnaser, I'm willing to help to get this merged as well.

[rogerioefonseca]

Any progress here? Would like to use this feature too and this seams to be the best maintained fork of the original repo.

Let me know if i can help bring this to an successful merge.

Not sure what else can I do as well.
@mnaser, I'm willing to help to get this merged as well.

Ping...

[yktakaha4]

@rogerioefonseca I also sent a PR to this repository, but since they seem to be busy, we decided to manage our own provider.
Heartbeat automation would be great for us, so please send me a PR if you'd like.
https://github.com/lapras-inc/terraform-provider-uptimerobot

[rogerioefonseca]

@rogerioefonseca I also sent a PR to this repository, but since they seem to be busy, we decided to manage our own provider. Heartbeat automation would be great for us, so please send me a PR if you'd like. https://github.com/lapras-inc/terraform-provider-uptimerobot

Nice, I'll do it on the weekend.

[dcardellino]

Any Update here? Would like to use this feature to not do this manually...