Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update project and make it buildable again #42

Merged
merged 23 commits into from
Mar 29, 2024

Conversation

vgaidarji
Copy link
Owner

@vgaidarji vgaidarji commented Mar 15, 2024

What has been done

  • Migrated from jcenter to mavenCentral
  • Migrated from Java to Kotlin
  • Updated Gradle to 8.4 version
  • Migrated from Fabric.Crashlytics to Firebase
  • Removed PMD, Checkstyle configurations as they not needed for Kotlin projects
  • Migrated to AndroidX and removed Butterknife in exchange of ViewBinding
  • Moved from Coveralls to codecov.io as Coveralls doesn't work well with Kotlin source code
  • Updated GitHub Actions CI/CD
  • Updated CircleCI CI/CD
  • Updated Bitrise CI/CD

What's left (will be the scope of another PRs)

  • Fix Jenkins
  • Fix Teamcity (and use new Teamcity Pipelines)
  • Configure ktlint

How to test

  • Verify build statuses on all fixed CIs and make sure nothing is wrong in logs (steps are not executed, coverage is not collected, etc.)
  • Make sure builds distributed to Firebase
  • Make sure code coverage is uploaded to codecov.io

Android Gradle Plugin now takes care of it.

WARNING: DSL element 'dexOptions' is obsolete and should be removed.
It will be removed in version 8.0 of the Android Gradle plugin.
Using it has no effect, and the AndroidGradle plugin optimizes dexing automatically.
Soon will migrate from Java to Kotlin
and jdepend won't be used anymore
Project no longer contains Java code.
Will migrate over to detekt tool.
@vgaidarji vgaidarji self-assigned this Mar 15, 2024
@vgaidarji vgaidarji force-pushed the make-android-project-buildable-again branch from 801de29 to 7934bef Compare March 15, 2024 10:52
@vgaidarji vgaidarji force-pushed the make-android-project-buildable-again branch from f601eb3 to b8b292b Compare March 15, 2024 11:58
@vgaidarji vgaidarji force-pushed the make-android-project-buildable-again branch 4 times, most recently from 58052d4 to 565f518 Compare March 15, 2024 19:21
@vgaidarji vgaidarji force-pushed the make-android-project-buildable-again branch from 565f518 to c631691 Compare March 15, 2024 19:24
@vgaidarji vgaidarji force-pushed the make-android-project-buildable-again branch from b19d940 to 586a113 Compare March 15, 2024 19:47
Using Ubuntu build machine instead of macOS,
which is significantly faster to spin up.
https://github.com/ReactiveCircus/android-emulator-runner
for more details about Android emulator test GitHub action config.
@vgaidarji vgaidarji force-pushed the make-android-project-buildable-again branch from d3f99ea to 03440ab Compare March 18, 2024 09:45
Coveralls has poor support for Kotlin source code.
Codecov does better job here.
@vgaidarji vgaidarji force-pushed the make-android-project-buildable-again branch 18 times, most recently from 45cc596 to 2d6cfdd Compare March 18, 2024 14:13
@vgaidarji vgaidarji force-pushed the make-android-project-buildable-again branch 3 times, most recently from 7f409f0 to d710da6 Compare March 18, 2024 15:55
@vgaidarji vgaidarji force-pushed the make-android-project-buildable-again branch from d710da6 to 8eaa8af Compare March 18, 2024 16:08
@vgaidarji vgaidarji force-pushed the make-android-project-buildable-again branch from 1a177c0 to 7bfc1d1 Compare March 29, 2024 07:53
@vgaidarji vgaidarji force-pushed the make-android-project-buildable-again branch from 7bfc1d1 to cf1b5ec Compare March 29, 2024 07:54
@vgaidarji vgaidarji merged commit 8925f33 into master Mar 29, 2024
8 checks passed
@vgaidarji vgaidarji deleted the make-android-project-buildable-again branch March 29, 2024 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant