Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving allocations #3

Open
RaviGaddipati opened this issue Nov 26, 2015 · 4 comments
Open

Moving allocations #3

RaviGaddipati opened this issue Nov 26, 2015 · 4 comments

Comments

@RaviGaddipati
Copy link

Was there a reason to do pvHStore, pvHLoad, pvHmax, and pvE memory allocations in the gssw_sw_sse2 functions? Moving the allocations up to graph_fill and reusing the same allocations for each node gave a huge performance boost.

@ekg
Copy link
Member

ekg commented Nov 26, 2015

Do you have a patch? It would require a recycler no? The size of the
allocated matrix will vary.
On Nov 26, 2015 10:00 PM, "Ravi Gaddipati" [email protected] wrote:

Was there a reason to do pvHStore, pvHLoad, pvHmax, and pvE memory
allocations in the gssw_sw_sse2 functions? Moving the allocations up to
graph_fill and reusing the same allocations for each node gave a huge
performance boost.


Reply to this email directly or view it on GitHub
#3.

@RaviGaddipati
Copy link
Author

No patch for this yet.
The size is dependent on segLen (i.e. readLen), and since that's the same for all nodes the allocation size is the same. Not sure what you mean by recycler.
I've been still getting accurate results with a modified version of gssw that does this (https://github.com/gaddra/gssw/tree/positional).

@ekg
Copy link
Member

ekg commented Nov 26, 2015

There is also pH, if I remember correctly. The entire score matrix. This
allocation could be recycled. The others yes absolutely. They should
definitely be refused directly!!!
On Nov 26, 2015 10:22 PM, "Ravi Gaddipati" [email protected] wrote:

No patch for this yet.
The size is dependent on segLen (i.e. readLen), and since that's the same
for all nodes the allocation size is the same.
I've been still getting accurate results with a modified version of gssw
that does this (https://github.com/gaddra/gssw/tree/positional).


Reply to this email directly or view it on GitHub
#3 (comment).

@RaviGaddipati
Copy link
Author

Ah yes, I had no use for traceback so I had removed mH. I'll make a pull request sometime soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants