Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix multithreaded GAM read #71

Open
adamnovak opened this issue Jul 10, 2024 · 1 comment
Open

Fix multithreaded GAM read #71

adamnovak opened this issue Jul 10, 2024 · 1 comment

Comments

@adamnovak
Copy link
Member

I had to turn off multithreaded GAM read because this would break on Mac:

vg construct -r test/1mb1kgp/z.fa -v test/1mb1kgp/z.vcf.gz > z.vg
vg sim -n 10000 -s 23 -a -x z.vg > sim.gam
# This fails
vg stats -a sim.gam
# This works
vg view -aj sim.gam | wc -l

Especially with --threads 1 to vg stats, I would get a signal 11 inside the wrapper code that makes a C++ input stream an hFILE implementation that htslib can read, if I enabled multithreading on the BGZF.

I probably need to make a small test C program or a test case in libvgio to make sure bgzf_mt isn't somehow broken on Mac, and gradually add more stuff to it until I can figure out what is going on.

I turned off multithreading in libvgio commit cb4a54c.

@adamnovak adamnovak self-assigned this Jul 10, 2024
@adamnovak
Copy link
Member Author

I don't think we actually need this for the paper, so I am kicking it off the paper board.

@adamnovak adamnovak removed their assignment Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant