-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make TBR default #1245
base: master
Are you sure you want to change the base?
Make TBR default #1245
Conversation
clang-tidy review says "All clean, LGTM! 👍" |
clang-tidy review says "All clean, LGTM! 👍" |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1245 +/- ##
=======================================
Coverage 94.66% 94.66%
=======================================
Files 51 51
Lines 8903 8903
=======================================
Hits 8428 8428
Misses 475 475
|
@guitargeek, can we check if this PR works with RooFit? |
I have already checked that on Cms and Atlas, so as long as those remain the same there is no need. |
Yes, the CMS and ATLAS likelihoods that I use for validations are still the same that I sent you guys. But building ROOT against Clad with this PR and see if the tests pass also does no harm. Doing that now. |
All RooFit tests passing after this patch, which is fixing compatibility with ROOT master independently of this PR: |
Fixes:#760