Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make TBR default #1245

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Make TBR default #1245

wants to merge 1 commit into from

Conversation

ovdiiuv
Copy link
Collaborator

@ovdiiuv ovdiiuv commented Feb 18, 2025

Fixes:#760

Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

Copy link

codecov bot commented Feb 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.66%. Comparing base (c99b0c4) to head (146360d).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1245   +/-   ##
=======================================
  Coverage   94.66%   94.66%           
=======================================
  Files          51       51           
  Lines        8903     8903           
=======================================
  Hits         8428     8428           
  Misses        475      475           
Files with missing lines Coverage Δ
tools/ClangPlugin.cpp 96.09% <100.00%> (ø)
Files with missing lines Coverage Δ
tools/ClangPlugin.cpp 96.09% <100.00%> (ø)

@vgvassilev
Copy link
Owner

@guitargeek, can we check if this PR works with RooFit?

@ovdiiuv
Copy link
Collaborator Author

ovdiiuv commented Feb 19, 2025

@guitargeek, can we check if this PR works with RooFit?

I have already checked that on Cms and Atlas, so as long as those remain the same there is no need.

@guitargeek
Copy link
Contributor

Yes, the CMS and ATLAS likelihoods that I use for validations are still the same that I sent you guys. But building ROOT against Clad with this PR and see if the tests pass also does no harm. Doing that now.

@guitargeek
Copy link
Contributor

guitargeek commented Feb 20, 2025

All RooFit tests passing after this patch, which is fixing compatibility with ROOT master independently of this PR:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants