Add support of variadic functions as call exprs in Forward mode #1246
+79
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes applied: * Use Call arg instead of Function param to store differentiation call's args * Create Unique Identifier for each param expanded from the pack of a variadic function * Add test
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -1104,6 +1121,7 @@ StmtDiff BaseForwardModeVisitor::VisitCallExpr(const CallExpr* CE) { | |||
| skipFirstArg = true; | |||
|
|
|||
| // For f(g(x)) = f'(x) * g'(x) | |||
| std::size_t numParams = FD->getNumParams(); | |||
There was a problem hiding this comment.
warning: no header providing "std::size_t" is directly included [misc-include-cleaner]
std::size_t numParams = FD->getNumParams();
^
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1246 +/- ##
=======================================
Coverage 94.66% 94.67%
=======================================
Files 51 51
Lines 8903 8918 +15
=======================================
+ Hits 8428 8443 +15
Misses 475 475
... and 5 files with indirect coverage changes
|
vgvassilev
reviewed
Feb 21, 2025
| @@ -3,20 +3,23 @@ | |||
|
|
|||
| #include "clad/Differentiator/Differentiator.h" | |||
|
|
|||
| #include "../TestUtils.h" | |||
| // CHECK: warning: function 'printf' was not differentiated because clad failed to differentiate it and no suitable overload was found in namespace 'custom_derivatives' | |||
There was a problem hiding this comment.
We should add -Xclang -verify and use the syntax of // expected-warning ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes applied: