Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify the reverse mode by having just one DiffMode for it #964

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Remove DerivePullback from ReverseModeVisitor and generate pullbacks …

5fb5536
Select commit
Loading
Failed to load commit list.
Open

Simplify the reverse mode by having just one DiffMode for it #964

Remove DerivePullback from ReverseModeVisitor and generate pullbacks …
5fb5536
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jul 22, 2024 in 1s

93.71% (-0.10%) compared to f03fc98, passed because coverage increased by -0.01% when compared to adjusted base (93.71%)

View this Pull Request on Codecov

93.71% (-0.10%) compared to f03fc98, passed because coverage increased by -0.01% when compared to adjusted base (93.71%)

Details

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.71%. Comparing base (f03fc98) to head (5fb5536).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #964      +/-   ##
==========================================
- Coverage   93.80%   93.71%   -0.10%     
==========================================
  Files          55       55              
  Lines        8065     7997      -68     
==========================================
- Hits         7565     7494      -71     
- Misses        500      503       +3     
Files Coverage Δ
include/clad/Differentiator/DiffMode.h 0.00% <ø> (ø)
include/clad/Differentiator/ReverseModeVisitor.h 98.18% <100.00%> (+0.30%) ⬆️
lib/Differentiator/DerivativeBuilder.cpp 100.00% <100.00%> (ø)
lib/Differentiator/DiffPlanner.cpp 98.71% <100.00%> (ø)
lib/Differentiator/ErrorEstimator.cpp 99.15% <100.00%> (+<0.01%) ⬆️
lib/Differentiator/HessianModeVisitor.cpp 99.54% <100.00%> (+0.01%) ⬆️
lib/Differentiator/ReverseModeVisitor.cpp 97.03% <100.00%> (-0.29%) ⬇️

... and 1 file with indirect coverage changes

Files Coverage Δ
include/clad/Differentiator/DiffMode.h 0.00% <ø> (ø)
include/clad/Differentiator/ReverseModeVisitor.h 98.18% <100.00%> (+0.30%) ⬆️
lib/Differentiator/DerivativeBuilder.cpp 100.00% <100.00%> (ø)
lib/Differentiator/DiffPlanner.cpp 98.71% <100.00%> (ø)
lib/Differentiator/ErrorEstimator.cpp 99.15% <100.00%> (+<0.01%) ⬆️
lib/Differentiator/HessianModeVisitor.cpp 99.54% <100.00%> (+0.01%) ⬆️
lib/Differentiator/ReverseModeVisitor.cpp 97.03% <100.00%> (-0.29%) ⬇️

... and 1 file with indirect coverage changes