Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy and invoke interfaces #491

Merged
merged 4 commits into from
Oct 18, 2024
Merged

Deploy and invoke interfaces #491

merged 4 commits into from
Oct 18, 2024

Conversation

cvetkovic
Copy link
Contributor

No description provided.

@cvetkovic
Copy link
Contributor Author

@leokondrashov: Any news on this PR?

Copy link
Contributor

@leokondrashov leokondrashov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, the review slipped through the cracks a bit.

cmd/config_knative_trace.json Outdated Show resolved Hide resolved
cmd/loader.go Outdated Show resolved Hide resolved
cmd/loader.go Show resolved Hide resolved
cmd/loader.go Outdated Show resolved Hide resolved
cmd/loader.go Show resolved Hide resolved
cmd/loader.go Outdated Show resolved Hide resolved
pkg/config/parser.go Show resolved Hide resolved
pkg/config/parser.go Show resolved Hide resolved
dhschall
dhschall previously approved these changes Oct 15, 2024
dhschall
dhschall previously approved these changes Oct 15, 2024
@cvetkovic cvetkovic dismissed dhschall’s stale review October 15, 2024 14:07

Workflow script issue.

Signed-off-by: Lazar Cvetković <[email protected]>
Signed-off-by: Lazar Cvetković <[email protected]>
Signed-off-by: Lazar Cvetković <[email protected]>
leokondrashov
leokondrashov previously approved these changes Oct 18, 2024
Copy link
Contributor

@leokondrashov leokondrashov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, the only question is about zipkin, see below.

Don't forget to log all ARs mentioned in the comments.

pkg/driver/clients/grpc_client.go Show resolved Hide resolved
Signed-off-by: Lazar Cvetković <[email protected]>
@cvetkovic cvetkovic merged commit f707dc5 into main Oct 18, 2024
15 checks passed
@cvetkovic cvetkovic deleted the deploy_invoke_interface branch October 18, 2024 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants