Refactor container image management #800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CuriousGeorgiy
force-pushed
the
image-management-refactoring
branch
from
db4f7c2
to
20a3bf4
Compare
CuriousGeorgiy
force-pushed
the
image-management-refactoring
branch
from
20a3bf4
to
683d1c8
Compare
leokondrashov
force-pushed
the
image-management-refactoring
branch
from
683d1c8
to
a5bb91c
Compare
CuriousGeorgiy
force-pushed
the
image-management-refactoring
branch
from
a5bb91c
to
0c154fc
Compare
|
@ustiugov I changed one line, but GitHub dismissed the review from you for some reason, could you please take a glance? |
Encapsulate container image management into a separate module that provides an image manager class. Closes vhive-serverless#799 Part of vhive-serverless#794 Signed-off-by: Georgiy Lebedev <[email protected]>
ustiugov
force-pushed
the
image-management-refactoring
branch
from
0c154fc
to
2ac0acd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #799
Part of #794
Implementation Notes ⚒️
ctriface/imageand a newImageManagerobject to manage container images.External Dependencies 🍀
Breaking API Changes⚠️