-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move to vanilla firecracker snapshots #816
Move to vanilla firecracker snapshots #816
Conversation
b0d35ac
to
0fb1459
Compare
2001bcd
to
9013471
Compare
a05913f
to
93fbcd2
Compare
@CuriousGeorgiy, there are several errors with lint and compiler (unused import and formatting). Please fix and push. |
eb7748a
to
a4e60a3
Compare
@leokondrashov done. |
a4e60a3
to
05855e1
Compare
05855e1
to
7e45704
Compare
Hello George, codes on this branch cannot pass firecracker-cri tests. Please check what is broken in the branch and make sure it passes the firecracker-cri tests, thank you! |
@lrq619 Hi! What you are saying is true, but at the same time:
So I don't know how to reproduce this issue, and I am not sure it is inherently related to my changes, it may as well be something like #781 or something related to #836. I have already addressed this to @leokondrashov and kindly asked him to take a look. |
let's postpone the gvisor upgrade and merge this PR. @leokondrashov, can you please proceed to a merge without the gvisor upgrade. in case of runner failure, please Ruiqi for help |
UPF feature for vanilla firecracker requires a separate integration effort (vhive-serverless#807), so temporarily disable this feature and all tests for it. Signed-off-by: Georgiy Lebedev <[email protected]>
@CuriousGeorgiy can you please rebase your branch so we can check the latest CI status? If the problem indeed persists, you have to debug it. if the problem is with the runners, we will take over (but as tests pass in
the logs are uploaded as artifacts, please check there. in future, please have your branches inside the vHive upstream repo, otherwise we cannot take over tasks from you. |
7e45704
to
cf5f5e6
Compare
The issue with PRs from forks was not connected to the accesses. It was pre-push hook that was trying to access fork's LFS which we don't need. |
As I said, I have checked the artifacts and haven't found any errors compared to the main branch. I have also tried setting up the CRI environment on a fresh CloudLab node (it succeeds) and running CRI tests there (it also succeeds), so I am not sure how I can debug the issue without access to the runners. |
Closes vhive-serverless#794 Signed-off-by: Georgiy Lebedev <[email protected]>
Signed-off-by: Georgiy Lebedev <[email protected]>
Signed-off-by: Georgiy Lebedev <[email protected]>
cf5f5e6
to
14e7759
Compare
@leokondrashov 1 meaningful difference I see in the containerd logs between this branch and the main branch is that on this branch containerd doesn't get any more requests after the |
I managed to make the test work. This was a strange behaviour of runner. Later the result might change because Ruiqi will be testing runners once again. But we can merge, finally. |
Summary
Closes #794
Implementation Notes ⚒️
ready
feature;Snapshot revisions
Snapshots are now identified by a function instance revision, which is naturally provided by the
K_REVISION
environment variable of knative1.External Dependencies 🍀
Breaking API Changes⚠️
Footnotes
https://knative.dev/docs/concepts/serving-resources/revisions/ ↩