Add bert benchmark #570
Closed
Add bert benchmark #570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: lrq619 <[email protected]>
ustiugov
requested changes
Jul 3, 2023
There was a problem hiding this comment.
Thank you! the code quality is good, well structured.
- update the dependabot config
- add CI for docker-compose and Knative
- make recommendations on configuration of the benchmark. The default configs should be easy to test in CI (e.g., w/o GPUs, 1 req instead of 100)
- create a PR for Adding a new benchmark to vSwarm (rename the file to
adding_new_benchmark.md)
| reservations: | ||
| devices: | ||
| - driver: nvidia | ||
| count: 2 |
There was a problem hiding this comment.
if we are to test it, it should work on CPU only.
docs/adding_standalone_benchmark.md
Outdated
| @@ -0,0 +1,58 @@ | |||
| # Adding Standalone Benchmarks in vSwarm | |||
| This is a detailed document of how to add a standalone benchmark in vSwarm. | |||
There was a problem hiding this comment.
not sure why "standalone", is it different for multi-function apps?
There was a problem hiding this comment.
Yes, this document is just for adding standalone benchmark, because multi-function apps might have different development procedure, for example, vSwarm-proto only contains protobuf for standalone functions, and multi-function benchmark doesn't rely on the relay docker instance, etc.
Signed-off-by: lrq619 <[email protected]>
ustiugov
approved these changes
Aug 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add bert as a standalone benchmark and also a document on how to write and test standalone benchmark locally.