Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add image classification benchmark to vSwarm #605

Closed
wants to merge 0 commits into from
Closed

Add image classification benchmark to vSwarm #605

wants to merge 0 commits into from

Conversation

manyiw99
Copy link

@manyiw99 manyiw99 commented Jul 9, 2023

Add image classification benchmark to vSwarm

ustiugov
ustiugov requested changes Jul 11, 2023
View reviewed changes
Copy link
Member

@ustiugov ustiugov left a comment •
edited by manyiw99
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Manyi.

  • Please add copyrights to all the files (our copyrights or the original copyrights if borrowed)
  • are Val-map and get-pip.py files are necessary?
  • Add CI

benchmarks/image_classification/README.md Outdated

The benchmark implements `Resnet50 model inference` on `Imagenet2012 val` dataset to do image classification. The implementation references [MLPerf Edge Inference Suite](https://github.com/mlcommons/inference/tree/master/vision/classification_and_detection).

The benchmark is implementated in Python.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Redundant

benchmarks/image_classification/docker/Dockerfile.cpu Outdated
@@ -0,0 +1,69 @@
FROM ubuntu:16.04
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super old, must be 20

benchmarks/image_classification/docker/Dockerfile.cpu Outdated Show resolved Hide resolved
benchmarks/image_classification/docker/Dockerfile.cpu Outdated
COPY benchmarks/image_classification/python /app

# Prepare dataset and model
# Here's the full dataset
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need the full dataset?

benchmarks/image_classification/python/server.py Outdated
import imagenet

from proto.image_classification import image_classification_pb2
# import image_classification_pb2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean

benchmarks/image_classification/yamls/docker-compose/dc-classification.yaml Outdated
@@ -0,0 +1,50 @@
# MIT License

# Copyright (c) 2023 Hyscale lab
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HyScale lab and vSwarm team

@manyiw99 manyiw99 marked this pull request as draft July 19, 2023 04:41
ustiugov
ustiugov requested changes Jul 19, 2023
View reviewed changes
Copy link
Member

@ustiugov ustiugov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • remove binaries from the commit history ILSVRC2012_img_val.zip and resnet50_v1.pb.zip. if necessary, it should be added to Git LFS (you can find examples in vHive repo bin/ folder)
  • merge the PR in the proto repo first

benchmarks/image_classification/docker/Dockerfile.cpu Outdated Show resolved Hide resolved
@manyiw99 manyiw99 closed this Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ustiugov ustiugov ustiugov requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@manyiw99 @ustiugov