Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix link-check CI #628

Merged
merged 2 commits into from
Jul 27, 2023
Merged

Fix link-check CI #628

merged 2 commits into from
Jul 27, 2023

Conversation

shyamjesal
Copy link
Collaborator

No description provided.

@shyamjesal shyamjesal force-pushed the fix-ci branch 2 times, most recently from cb370f4 to bfe0b7d Compare July 27, 2023 16:17
ignore twitter url as it is auth-walled now.
ignore intel url as it returns 403

Signed-off-by: Shyam Jesal <[email protected]>
@shyamjesal shyamjesal force-pushed the fix-ci branch 2 times, most recently from 2257d24 to dde081a Compare July 27, 2023 16:31
@shyamjesal shyamjesal merged commit 4ad2878 into main Jul 27, 2023
@shyamjesal shyamjesal deleted the fix-ci branch July 27, 2023 16:57
@ustiugov
Copy link
Member

ustiugov commented Aug 2, 2023

@shyamjesal please don't forget to request one review.

@ustiugov
Copy link
Member

ustiugov commented Aug 2, 2023

what was the reason for the private-registries change? also, why is it left commented and not removed as the PR comment says?

@shyamjesal
Copy link
Collaborator Author

We were not using any private-registry to upload-download, and a recent change in the github policy broke the dependabot. The policy prevented the use of github secrets in dependabot triggered actions. Ref: dependabot/dependabot-core#3253

It is left as a comment for reference in case we need it in future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants