Warn client when Invocation fail #634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The PR depends on vhive-serverless/vSwarm-proto#72. |
Before the relay panics when the function not repond in time or something breaks. Instead of breaking we send back a waring to the invoking client. Signed-off-by: David Schall <[email protected]>
shyamjesal
approved these changes
Feb 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #629
Before the relay panics when the function did
not respond in time or something breaks.
Instead of breaking, we send back a warning to the
invoking client.
Furthermore I fixed a small bug I found in the invoker:
If the RPS is larger than 1000 the duration is 0.
The timer will not trigger any request.
Now the Invoker can handle RPS up to microseconds.
Furthermore, if the RPS is too high it will
warn the user.