Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add image classification bench #676

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add image classification bench #676

wants to merge 1 commit into from

Conversation

lrq619
Copy link
Contributor

@lrq619 lrq619 commented Sep 16, 2023

Manyi's branch

ustiugov
ustiugov reviewed Sep 26, 2023
View reviewed changes
benchmarks/image_classification/docker/Dockerfile.cpu
unzip resnet50_v1.pb.zip && \
rm -rf resnet50_v1.pb.zip

# Here's one image sample used to test Dockerfile
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please clean up the commented part

ustiugov
ustiugov requested changes Sep 26, 2023
View reviewed changes
Copy link
Member

@ustiugov ustiugov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • store binaries in Git LFS, not in the repo. You need to purge the commit which adds a binary
  • fix the versions in the dependency file
  • configure dependabot to track the dependency file(s)
  • remove get-pip.py (?)

benchmarks/image_classification/requirements.txt
future pillow onnx opencv-python-headless tensorflow
Cython
pycocotools
protobuf==3.20.*
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use fixed versions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ustiugov ustiugov ustiugov requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lrq619 @ustiugov