Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade go version to 1.21 #703

Merged
merged 1 commit into from
Oct 18, 2023
Merged

Upgrade go version to 1.21 #703

merged 1 commit into from
Oct 18, 2023

Conversation

dhschall
Copy link
Contributor

@dhschall dhschall commented Oct 3, 2023 •
edited
Loading

  • Update base-images
  • Update mod files
  • Update CI workflows

resolves #691

  • Updated deprecated go versions rand and ioutils

@dhschall dhschall force-pushed the upgrade-go branch 2 times, most recently from 94b20a3 to 957152b Compare October 4, 2023 12:05
ustiugov
ustiugov requested changes Oct 17, 2023
View reviewed changes
Copy link
Member

@ustiugov ustiugov left a comment •
edited by dhschall
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • the right syntax is go-version: '1.21', note the quotes. we had this problem before
  • revert ubuntu upgrade. let's leave it at 20 and then upgrade to 22 (but not "latest", it's dangerous)

.github/workflows/base-images.yml Outdated Show resolved Hide resolved
@dhschall
Upgrade go version to 1.21
bef4daf 
- Update base-images
- Update mod files
- Update CI workflows
- Update some deprecated functions

Signed-off-by: David Schall <[email protected]>
ustiugov
ustiugov approved these changes Oct 18, 2023
View reviewed changes
Copy link
Member

@ustiugov ustiugov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Skimmed, lgtm. I suggest to run the first round of reviews by Shyam in future to avoid delays in reviewing.

@dhschall
Copy link
Contributor Author

Thanks @ustiugov. @shyamjesal is in India at the moment otherwise I would not have bothered you :)

@dhschall dhschall merged commit 90429b7 into main Oct 18, 2023
172 of 179 checks passed
@dhschall dhschall deleted the upgrade-go branch October 18, 2023 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ustiugov ustiugov ustiugov approved these changes

@shyamjesal shyamjesal Awaiting requested review from shyamjesal

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade go version
2 participants
@dhschall @ustiugov