feat: Add bitflags type (WindowFlags) for SDL_WindowFlags
#252
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yonzebu
changed the title
WindowFlags) for SDL_WindowFlagsWindowFlags) for SDL_WindowFlags
yonzebu
changed the title
WindowFlags) for SDL_WindowFlagsWindowFlags) for SDL_WindowFlags
yonzebu
force-pushed
the
window-flags-bitflags
branch
from
a71a255 to
c38eba4
Compare
yonzebu
force-pushed
the
window-flags-bitflags
branch
from
c38eba4 to
308c78f
Compare
|
Sorry about those renames/force pushes, I am not particularly familiar with opening PRs. |
No worries, thanks for your contribution! Would you mind terribly running cargo fmt |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using a raw
u32for window flags works, but it's not nearly as nice for discoverability or usability as a dedicated bitflags type (right now using window flags requires using the relevant consts in sdl3_sys). Also, it's not forward compatible if SDL3 adds too many new window flags since SDL3's window flags areu64.Changes
WindowFlagsbitflags wrapper aroundSDL_WindowFlagsWindowFlagsinternally forWindowBuilder/PopupWindowBuilderflags/set_flagsmethods toWindowBuilder/PopupWindowBuilder, which useWindowFlagsinstead ofu32(changingwindow_flags/set_window_flagswould be a semver breaking change, I can open a second PR to do that if it would be desirable)