Skip to content

Conversation

@Stromdahl
Copy link

Hey! I was experimenting with the library and noticed draw_rect and fill_rect handle parameters differently. There could be a good reason for this, but just in case there
isn't, here's a small patch to make them consistent.

Updated Canvas::draw_rect to accept R: Into<FRect> like fill_rect does

@Stromdahl Stromdahl changed the title make draw_rect consistent with fill_rect generic paramete feat: make draw_rect consistent with fill_rect generic parameter Nov 3, 2025
@Stromdahl Stromdahl changed the title feat: make draw_rect consistent with fill_rect generic parameter feat: make draw_rect consistent with fill_rect generic parameter Nov 3, 2025
@revmischa
Copy link
Member

Thanks!

@revmischa
Copy link
Member

I think some examples etc will need to be updated

@Stromdahl
Copy link
Author

No problem, i will look in to that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants