Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated releases #38

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Automated releases #38

wants to merge 7 commits into from

Conversation

crabhi
Copy link

@crabhi crabhi commented Sep 25, 2023

Hi, we use your plugin. To be able to upgrade ES versions, I've automated the release process. If you're interested in it, here you are.

There are a few smaller changes bundled:

  • Tests were not being run because Log4j 3.0 alpha1 was used. I couldn't make it work with version range so I just hardcoded Log4j version - the same as other dependencies.
  • It seems enough to get Lucene that comes with ES and we don't need to specify its version here.
  • I separated this plugin version number from the ES version number. Basically copied from monitora-media/es-utils where we need to make changes to the plugin independently from ES upgrades.

@vhyza
Copy link
Owner

vhyza commented Mar 1, 2024

Hi @crabhi,

thank you for the PR. I'm sorry I didn't get back to you sooner. I'm quite swamped with other projects and as I do not use the plugin for years now, my motivation is not the strongest.

Anyway, I'd like to get back one day, but it will probably take some more time. I'm sorry about that.

@crabhi
Copy link
Author

crabhi commented Mar 1, 2024

No worries! It's not blocking me in any way. 😃

@crabhi
Copy link
Author

crabhi commented Mar 1, 2024

And thanks for your open source project. Had it been closed, it would be much harder to keep it up to date. 🙇🏿

@pySilver
Copy link

pySilver commented Jul 4, 2024

@vhyza your plugin is awesome. maybe someone would like to take over and maintain it?

@vhyza
Copy link
Owner

vhyza commented Jul 4, 2024

Hi @pySilver,

thank you for your kind words.

I hope I'll find some time during the summer to finally process the pending issues and pull requests.

The problem is that the plugin release is still a somewhat manual process. I thought about the CI/CD pipeline for a long time, but as the manual publish is approx 10 minutes per elasticsearch version I always rather do the release.

That was fine when I had time to do it before new elasticsearch versions started to accumulate.

As I released more than 150 versions of the plugin I'd like to release all the missing versions. Ideally not manually :-).

So I was thinking that I first try to get changes from this PR made by @crabhi, especially to try the GitHub workflow and dependency changes together with the work made by @vit-zikmund in #39.

After the dependencies are updated and resolved (like Log4j etc) I'd like to "stress-test" the workflow to release the missing versions and process the rest of the PRs:

Also if the Workflow somehow allows starting elasticsearch with some particular version (for example using git tag as all releases are tagged) I think it would be nice to add a test which installs the generated plugin and runs simple sh script testing that the plugin works by sending curl request to for example _analyze elasticsearch endpoint.

To be honest I never used GitHub Workflows (I am more familiar with Gitlab-CI or CircleCI) so I do not know yet if the following is possible. I was thinking something like:

  • when a new tag is pushed workflow starts
  • run Java tests
  • build a plugin if Java tests passed
  • install the plugin using the correct elasticsearch version
  • run elasticsearch with the plugin installed
  • run test script
  • if everything is ok, release the result as a new GitHub release

As the pending PRs sometimes overlap I probably won't be processing the PRs as a whole but most likely cherry-picking the changes. I'll try my best to keep the credit.

I really appreciate all the work done in the PRs ❤️. I hope during my summer vacation I'll have some time and energy to start the work. If not and there is someone who would like to help with it I can add him/her as a repository collaborator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants