-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[win32] Revert and adapt fix for coordinate system for rescaling scenario #1590
[win32] Revert and adapt fix for coordinate system for rescaling scenario #1590
Conversation
Test Results 483 files ±0 483 suites ±0 8m 11s ⏱️ -11s For more details on these failures, see this check. Results for commit 428846c. ± Comparison against base commit d9d9bf0. ♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR fixes the issue it describes (I tested).
I only have some minor comments regarding unnecessary else
blocks and 1 question regarding what seems to be a change in the original code (which used autoScaleDown
).
Other than that, the PR looks good. @akoch-yatta if you can address my comments then I'd like to request PMC approval to merge this one for M3.
bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/widgets/Control.java
Outdated
Show resolved
Hide resolved
bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/widgets/Control.java
Outdated
Show resolved
Hide resolved
bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/widgets/Display.java
Outdated
Show resolved
Hide resolved
bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/widgets/Display.java
Outdated
Show resolved
Hide resolved
bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/widgets/Display.java
Outdated
Show resolved
Hide resolved
bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/widgets/Display.java
Outdated
Show resolved
Hide resolved
bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/widgets/Shell.java
Outdated
Show resolved
Hide resolved
bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/widgets/Shell.java
Outdated
Show resolved
Hide resolved
bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/widgets/Display.java
Outdated
Show resolved
Hide resolved
b2aed6b
to
e9da217
Compare
This commit reapplies the essence of the reverted commits from 4f60cb6 and 7a04f7a with proper guards to differentiate between the scenario with rescaling active and inactive. contributes to eclipse-platform#62 and eclipse-platform#127
e9da217
to
428846c
Compare
Requesting PMC approval to merge this one since we're on "RC1 stabilization" phase: @akurtakov / @merks |
BTW the test failures are unrelated |
+1 I will defer to you guys' good judgement. |
While testing we noticed some regressions, that were introduced with the commits 4f60cb6 and 7a04f7a. These commits were focused on providing a proper point coordinate system when multiple zoom values are involved and rescaling at runtime is active, but they also introduced behavioral changes when the rescaling at runtime is not active.
There are mainly three possible approaches to handle this regression:
This PR uses the 3rd approach. The first commit is a squashed commit to revert 4f60cb6 and 7a04f7a. The second commit reintroduces the changes with guards.
One scenario to test
Primary Monitor: 125% (Left)
Secondary Monitor: 175% (Right)
When moving the workbench to the secondary monitor and opening the search window, the window appears on the primary (fallback) monitor instead of the secondary monitor.