Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow relative links #26

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Allow relative links #26

wants to merge 6 commits into from

Conversation

Saquith
Copy link

@Saquith Saquith commented Jun 9, 2021

I ran into an API witih relative links, with some overlapping parts, i.e. https://example.uri.com/endpoint, containing links like /endpoint/example/id.
This resulted in some Uri exceptions, since it wasn't a proper full Uri.

It's optionally changed by setting the property AllowRelativeLinks in the IHalKitConfiguration, which results in the LinkResolver creating a new href from the relative path using the absolute path as base.

In the example, it takes the AbsolutePath from the example uri /endpoint and replaces it with the empty string, so the full AbsoluteUri can be joined with the remaining relative path /example/id.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant