Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RSDK-7442] Update deps with moderate severity security issues #40

Merged
merged 1 commit into from
Apr 29, 2024

Conversation

hexbabe
Copy link
Collaborator

@hexbabe hexbabe commented Apr 29, 2024

#33
#32
#21

Dependabot has marked multiple dependencies in our Go integration test module as having "moderate severity" security issues. This consolidates all the suggested changes into one PR. Verified that the integration tests still work on linux/arm64

rawr-ubuntu@rawr-ubuntu:~/Projects/viam-camera-realsense$ /home/rawr-ubuntu/Projects/viam-camera-realsense/packaging/appimages/deploy/realsense-integration-tests-latest-aarch64.AppImage -module /home/rawr-ubuntu/Projects/viam-camera-realsense/packaging/appimages/deploy/viam-camera-realsense-latest-aarch64.AppImage
VIAM REALSENSE MODULE INTEGRATION TESTS
Tests defined at https://github.com/viamrobotics/viam-camera-realsense/tree/main/integration/tests
checking if file exists at "/home/rawr-ubuntu/Projects/viam-camera-realsense/packaging/appimages/deploy/viam-camera-realsense-latest-aarch64.AppImage"
Starting the tests...
PASS
all tests succeeded!

@hexbabe hexbabe marked this pull request as ready for review April 29, 2024 15:51
@hexbabe hexbabe requested a review from nicksanford April 29, 2024 15:52
@@ -73,10 +73,10 @@ require (
github.com/klauspost/compress v1.16.5 // indirect
github.com/kylelemons/go-gypsy v1.0.0 // indirect
github.com/lestrrat-go/backoff/v2 v2.0.8 // indirect
github.com/lestrrat-go/blackmagic v1.0.1 // indirect
github.com/lestrrat-go/blackmagic v1.0.2 // indirect

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these packages only used in tests?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep

@nicksanford
Copy link

@hexbabe Please confirm tests still pass on all other supported platforms. Once you do you can merge it

@hexbabe
Copy link
Collaborator Author

hexbabe commented Apr 29, 2024

@hexbabe Please confirm tests still pass on all other supported platforms. Once you do you can merge it

Docker for Mac worked for building a linux/amd64 appimage for these integration tests! Tested the amd64 appimage works on the UP board

viam@viam:~$ ./realsense-integration-tests-latest-x86_64.AppImage  -module ./viam-camera-realsense-latest-x86_64.AppImage 
VIAM REALSENSE MODULE INTEGRATION TESTS
Tests defined at https://github.com/viamrobotics/viam-camera-realsense/tree/main/integration/tests
checking if file exists at "./viam-camera-realsense-latest-x86_64.AppImage"
Starting the tests...
PASS
all tests succeeded!

@hexbabe hexbabe merged commit 9269e3e into main Apr 29, 2024
3 checks passed
@hexbabe hexbabe deleted the APP-4646 branch April 29, 2024 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants