Merge pull request #22 from jckras/fatal

RSDK-8853: Replace fatal with test.That in do_command tests
viam-modules · Oct 11, 2024 · 7b3c05d · 7b3c05d
2 parents 046765b + 41f4e18
commit 7b3c05d
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 15 deletions.
diff --git a/tests/config_test.go b/tests/config_test.go
@@ -79,9 +79,7 @@ func testVideoPlayback(t *testing.T, videoPath string) {
 
 func TestModuleConfiguration(t *testing.T) {
 	fullModuleBinPath, err := getModuleBinPath()
-	if err != nil {
-		t.Fatalf("Failed to get module binary path: %v", err)
-	}
+	test.That(t, err, test.ShouldBeNil)
 
 	// Full configuration
 	config1 := fmt.Sprintf(`

diff --git a/tests/fetch_test.go b/tests/fetch_test.go
@@ -14,13 +14,9 @@ import (
 func TestFetchDoCommand(t *testing.T) {
 	storageRelativePath := "./video-storage"
 	storagePath, err := filepath.Abs(storageRelativePath)
-	if err != nil {
-		t.Fatalf("Failed to get absolute path: %v", err)
-	}
+	test.That(t, err, test.ShouldBeNil)
 	fullModuleBinPath, err := getModuleBinPath()
-	if err != nil {
-		t.Fatalf("Failed to get module bin path: %v", err)
-	}
+	test.That(t, err, test.ShouldBeNil)
 
 	config1 := fmt.Sprintf(`
 	{

diff --git a/tests/save_test.go b/tests/save_test.go
@@ -15,13 +15,9 @@ import (
 func TestSaveDoCommand(t *testing.T) {
 	storageRelativePath := "./video-storage"
 	storagePath, err := filepath.Abs(storageRelativePath)
-	if err != nil {
-		t.Fatalf("Failed to get absolute path: %v", err)
-	}
+	test.That(t, err, test.ShouldBeNil)
 	fullModuleBinPath, err := getModuleBinPath()
-	if err != nil {
-		t.Fatalf("Failed to get module bin path: %v", err)
-	}
+	test.That(t, err, test.ShouldBeNil)
 
 	config1 := fmt.Sprintf(`
 	{