[RSDK-8903] - Implement simple keyframe force interval #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hexbabe
approved these changes
Oct 4, 2024
hexbabe
reviewed
Oct 4, 2024
go.mod
Outdated
| @@ -14,6 +14,7 @@ require ( | |||
| go.viam.com/rdk v0.40.0 | |||
| go.viam.com/test v1.1.1-0.20220913152726-5da9916c08a2 | |||
| go.viam.com/utils v0.1.98 | |||
| golang.org/x/exp v0.0.0-20240103183307-be819d1f06fc | |||
There was a problem hiding this comment.
Forgot to run go mod tidy from last PR.
But thanks for pointing this out, for some reason I was using the external package instead of math/rand.
There was a problem hiding this comment.
Removed that dep from example script.
hexbabe
reviewed
Oct 4, 2024
seanavery
commented
Oct 4, 2024
| @@ -9,6 +9,7 @@ package main | |||
|
|
|||
| import ( | |||
| "context" | |||
| "math/rand" | |||
There was a problem hiding this comment.
Small fix for a tidy mod.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There was an issue where the segmenter would flake out after some time. This was due to a keyframe not being correctly inserted into the beginning of the segment as expected. It turns out, the
gop_sizeencoder settings are more of a recommendation than an absolutely firm keyframe interval. Dependenging on scene changes, a keyframe could be inserted earlier than expected throwing off the synchronization between the encoder and segmenter.FFmpeg codec options actually include a
force_key_framesexpression handler, so we do not even have to hand roll the key frame forces in our image loop! Basically a one line opt call to fix this : )Test
viamrtspcamera of size 960x480 and 20FPS2024-10-03_17-48-40.mp4
ffprobe -v error -select_streams v:0 -show_frames -print_format json 2024-10-03_17-48-40.mp4 > frames_info.jsonframes_info.json
Update here after overnight test: ✅