Fix carousel javascript error

viamrobotics · Sep 8, 2023 · f942238 · f942238
1 parent 37cfca4
commit f942238
Show file tree

Hide file tree

Showing 5 changed files with 11 additions and 5 deletions.
diff --git a/static/js/carousel.js → assets/js/carousel.js b/static/js/carousel.js → assets/js/carousel.js
@@ -32,8 +32,10 @@ document.addEventListener('DOMContentLoaded', function() {
           });
           const scrolllength = carousel.querySelector('ul li:nth-child(2)').offsetLeft - carousel.querySelector('ul li:nth-child(1)').offsetLeft;
           const nthchild = (Math.round((ele.scrollLeft/scrolllength)+1));
-          carousel.querySelector('ol li:nth-child('+nthchild+')').classList.add('selected');
-          carousel.querySelector('ul li:nth-child('+nthchild+')').classList.add('selected');
+          let ol_elem = carousel.querySelector('ol li:nth-child('+nthchild+')');
+          let ul_elem = carousel.querySelector('ul li:nth-child('+nthchild+')');
+          if (ol_elem) { ol_elem.classList.add('selected'); }
+          if (ul_elem) { ul_elem.classList.add('selected'); }
           if(carousel.parentElement.parentElement.querySelector('.dynamictitle')) {
               const title = carousel.querySelector('ul li:nth-child('+nthchild+') img').getAttribute('title');
               if(title) carousel.parentElement.parentElement.querySelector('.dynamictitle').innerHTML = title;

diff --git a/static/js/tutorials.js → assets/js/tutorials.js b/static/js/tutorials.js → assets/js/tutorials.js
diff --git a/docs/_index.md b/docs/_index.md
@@ -217,4 +217,6 @@ sitemap:
   </div>
 </div>
 
-<script type="text/javascript" src="js/carousel-min.js"></script>
+{{ $jsCarousel := resources.Get "js/carousel.js" }}
+{{ $jsCarousel := $jsCarousel | minify }}
+<script type="text/javascript" src="{{ $jsCarousel.RelPermalink }}" crossorigin="anonymous"></script>
diff --git a/layouts/docs/tutorials.html b/layouts/docs/tutorials.html
@@ -80,7 +80,10 @@ <h4 class="alert-heading">Javascript</h4>
     <script src="https://cdn.jsdelivr.net/npm/typesense-instantsearch-adapter@2/dist/typesense-instantsearch-adapter.min.js"></script>
 
     <script src="https://cdn.jsdelivr.net/npm/[email protected]"></script>
-    <script src="../js/tutorials.js"></script>
+
+    {{ $jsTutorials := resources.Get "js/tutorials.js" }}
+    {{ $jsTutorials := $jsTutorials | minify }}
+    <script type="text/javascript" src="{{ $jsTutorials.RelPermalink }}" crossorigin="anonymous"></script>
 
   </body>
 </html>
diff --git a/static/js/carousel-min.js b/static/js/carousel-min.js