-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOCS-923: Document viam:camera:csi
modular camera as model for the Jetson Orin Nano's embedded camera
#1716
DOCS-923: Document viam:camera:csi
modular camera as model for the Jetson Orin Nano's embedded camera
#1716
Conversation
csi
camera module for the Jetson Orin Nano's embedded cameracsi
camera module for the Jetson Orin Nano's embedded camera
csi
camera module for the Jetson Orin Nano's embedded cameraviam:camera:csi
modular camera as model for the Jetson Orin Nano's embedded camera
--- | ||
|
||
|
||
Viam provides a modular resource [extending](/extend/modular-resources/) the [camera API](/components/camera/#api) as a new `viam:camera:csi` model of [camera](/components/camera/). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thin kyou want to provide the value before the explanation - what does this resource allow readers to do?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok done I think. Sentence is a little bare though-- maybe revisit this feedback tmrw
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(I will revisit)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added more talking about what I think is the value-add of CSI cameras and explaining more about what they are-- lmk what you think. Using info from here but not sure whether or not to link @npentrel https://embeddedcomputing.com/technology/analog-and-power/mipi-csi-2-v3-0-enhances-imaging-reduces-cabling-for-embedded-systems-designers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is good but I think what's missing is why I'd need to use this over the normal camera component - see suggestion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This sounds good. In the context of Jetson devices one of the major advantages is using the hardware-accelerated ISP (image signal processing) library on the host machine called libargus.
Also, mechanically reliable connection from the camera to the host machine on mobile robotics platforms. (As opposed to using usb cables/ports).
|
||
The module is open-sourced and available on [GitHub](https://github.com/seanavery/viam-csi). | ||
|
||
[Install requirements](#requirements) and [configure](#configuration) the module to add an `viam:camera:csi` [camera](/components/camera/) {{< glossary_tooltip term_id="resource" text="resource" >}} to your robot. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing article in Install requirements
but that also doesn't sound super great? Should that be "get the modular resouce" or something like that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmmm I can change here but I don't know if we actually need to change the beginning of the sentence! I think that without article is actually the normal way to say it, but I could be wrong 😆 Requirements as a noun and directive, right? Like a medium article?
Co-authored-by: Naomi Pentrel <[email protected]>
--- | ||
|
||
|
||
Viam provides a modular resource [extending](/extend/modular-resources/) the [camera API](/components/camera/#api) as a new `viam:camera:csi` model of [camera](/components/camera/). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is good but I think what's missing is why I'd need to use this over the normal camera component - see suggestion.
|
||
Check the [**Logs** tab](/program/debug/) of your robot in the Viam app to make sure your camera has connected and no errors are being raised. | ||
|
||
The following attributes are available for the `viam:camera:csi` model: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding the attribute parameters!
On your robot's computer, download [the `viam:camera:csi` appimage](https://github.com/viamrobotics/odrive) and make it executable: | ||
|
||
``` {class="command-line" data-prompt="$"} | ||
sudo wget https://github.com/seanavery/viam-csi/releases/download/v0.0.2/viam-csi-0.0.2-aarch64.AppImage -O /usr/local/bin/viam-csi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We will want to update the install instructions once it is uploaded to the module registry.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking good! Concise and should provide users enough information to get started with the csi-camera module. If it is deemed necessary we can provide more context on the why of using csi cameras and more detailed recommendations for purchasing compatible cameras.
Co-authored-by: Naomi Pentrel <[email protected]>
Co-authored-by: Naomi Pentrel <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left two more comments, otherwise LGTM.
So there's one more issue and that is that the examples top level page doesn't list this and should - otherwise it's not very findable. Please add it there before merging.
Co-authored-by: Naomi Pentrel <[email protected]>
Thank you for catching that! Have added. And applied the array suggestions inline. |
You can view a rendered version of the docs from this PR at https://docs-test.viam.dev/813961db4c430b77e70dad927acf76b6bb791d48/public |
Is not just for the
jetson
, is meant for thepi
as well in the futureSME: @seanavery