Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOCS-906: Document
wheeled-odometry
model of movement sensor #1734DOCS-906: Document
wheeled-odometry
model of movement sensor #1734Changes from 24 commits
dfcd2b5
366cabf
4975d81
8d20302
9cc187d
f801f13
4afa892
45eb353
e968221
047e2cd
0b589d4
3a761f2
4c897d8
5b503f4
eff3ebd
e7f6bc8
c9f4d34
0d485e5
eef4f19
904d382
26dc6df
b845418
138bd6c
8cb1e0d
8858a08
5b8efa3
8095af2
0a657dd
24dc836
af320a2
72afcd6
5a8a967
498f4f0
4ed6cea
e07588d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: extra
movement sensor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
haha removed! MAking better tags
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does
This model
refer to?wheeled-odometry
is introduced as amovement sensor
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added clarification that it is movement sensor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unsure: Does this require
depends_on
like other things that function as other components? (Like the visual odometry sensordepends_on
acamera
.) I think ... no?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the validation function of most built-in models appends all dependencies, they are implicit and don't need to be explicitly configured.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
but they will show up in your config once added as dependencies, you just don't have to configure them as a user - we use the helper functions to do that for you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, thanks @randhid !