Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix JSON indentation on modular config doc #1767

Merged
merged 1 commit into from
Sep 7, 2023

Conversation

JessamyT
Copy link
Collaborator

@JessamyT JessamyT commented Sep 7, 2023

Also applies a small body text change that was applied to the similar words in the other part of the doc.

@viambot viambot added the safe to build This pull request is marked safe to build from a trusted zone label Sep 7, 2023
@viambot
Copy link
Member

viambot commented Sep 7, 2023

You can view a rendered version of the docs from this PR at https://docs-test.viam.dev/8af91d74b9a8af5a6e99c47e623b2b7adc5fb404/public

Copy link
Contributor

@andf-viam andf-viam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for making this change.

@@ -84,7 +84,7 @@ If, for example, the module provides a motor component, and the motor is running

### Configure a modular resource from a Registry module

Once you have configured a module from the Viam Registry, you can add any number of the resources that module makes available to your robot by adding new components or services configured with your modular resources' new subtype or [model](/extend/modular-resources/key-concepts/#models).
Once you have configured a module from the Viam Registry, you can add any number of the resources that the module makes available to your robot by adding new components or services configured with your modular resources' [model](/extend/modular-resources/key-concepts/#models).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you I must have brained incoming | current wrong 👍

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haha I don't even know any more--this text was (and is) in two places so I think we both only caught one of them before :D

@JessamyT JessamyT merged commit df5161b into viamrobotics:main Sep 7, 2023
5 checks passed
@JessamyT JessamyT deleted the followup branch September 7, 2023 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
safe to build This pull request is marked safe to build from a trusted zone
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants