Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOCS-1060, DOCS-1091: Add GitHub Action upload #1782

Merged

Conversation

andf-viam
Copy link
Contributor

@andf-viam andf-viam commented Sep 8, 2023

Add instructions to update an existing module in the Viam Registry using the new GitHub action upload-module from https://github.com/viamrobotics/upload-module.

  • Also updating all instances of old app.viam.com/modules slug to new app.viam.com/registry, except for module pages themselves, which still use module singular.
  • Also expanding where we link directly to the Registry. LMK if overkill.
  • Also lowercase registry everywhere per recent guidance.
  • Also .... I guess removing the beta warning? Something tells me ...

Staging

@viambot viambot added the safe to build This pull request is marked safe to build from a trusted zone label Sep 8, 2023
@andf-viam andf-viam requested a review from abe-winter September 8, 2023 20:52
@andf-viam
Copy link
Contributor Author

Hi @abe-winter ! Sorry for Friday ping: here's the docs around your awesome github action upload-module. Thanks for a great README!!

Copy link
Member

@abe-winter abe-winter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

slightly antsy about having two copies of the docs for the action (readme + this). They could diverge. I'd be fine with you owning the README in viamrobotics/upload-module + making changes as needed, but this is your call

You can update an existing module in the [Viam Registry](https://app.viam.com/registry) in one of two ways:

- [Upload a newer version of your module manually](#update-an-existing-module-using-the-viam-cli) using the [Viam CLI](/manage/cli/).
- [Upload a newer version of your module automatically](#update-an-existing-module-using-a-github-action) as part of a continuous integration (CI) workflow, using a GitHub Action.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

phrasing slightly confusing bc it sounds like you are doing this once

might change to 'upload new versions' or 'automatically upload on release' or something

(but this is a nit)

1. Next, follow the instructions to [Create an organization API key](/manage/cli/#create-an-organization-api-key), which the action will use to authenticate its run.
Provide the `key-id` and `key-value` generated in the YAML configuration above.

1. Push a commit to your module or [create a new release](https://docs.github.com/en/repositories/releasing-projects-on-github).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'each commit' vs 'only github release' vs 'only tag release' workflows are subtly different

I didn't doc too deeply in the action's README.md because this is a general github thing, not a viam thing. your call whether to say anything about it here, but FYI

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, added a "your specific steps may differ" callout. 👍

@andf-viam andf-viam force-pushed the DOCS-1060-add-registry-github-action-docs branch from 9391770 to 7c67a56 Compare September 11, 2023 15:28
@viambot
Copy link
Member

viambot commented Sep 11, 2023

You can view a rendered version of the docs from this PR at https://docs-test.viam.dev/d392353b3548f3f917763e63c3ba3b7fd4c7291e/public

@andf-viam andf-viam merged commit 593007b into viamrobotics:main Sep 11, 2023
5 checks passed
@andf-viam andf-viam deleted the DOCS-1060-add-registry-github-action-docs branch September 11, 2023 21:31
@npentrel npentrel mentioned this pull request Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
safe to build This pull request is marked safe to build from a trusted zone
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants