-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOCS-1113: Add clarification for running code remotely to client SDK Run Code page #1819
Merged
sguequierre
merged 11 commits into
viamrobotics:main
from
sguequierre:DOCS-1113/improve-run-page
Sep 21, 2023
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
c42c62c
Add clarification for running code remotely
sguequierre 934ec09
Apply suggestions from code review
sguequierre 9209404
Apply suggestions from code review
sguequierre 22d3d84
Apply suggestions from code review
sguequierre b0b554c
Apply suggestions from code review
sguequierre a590261
Apply suggestions from code review
sguequierre e3bb471
Apply suggestions from code review
sguequierre 36c579a
Apply suggestions from code review
sguequierre d801921
Update run.md use case
sguequierre 0467b87
Apply suggestions from code review
sguequierre 0110904
Update run.md
sguequierre File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think a user would know what they are supposed to do to "reference a robot's location secret", maybe include or add would be better?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh I see now you were just movign this up... We can fix it separetely