Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ramp_rate attribute on encoded motor #1869

Merged
merged 2 commits into from
Sep 20, 2023
Merged

Update ramp_rate attribute on encoded motor #1869

merged 2 commits into from
Sep 20, 2023

Conversation

JessamyT
Copy link
Collaborator

@JessamyT JessamyT commented Sep 19, 2023

Seems like this is the actual JSON attribute name as of viamrobotics/rdk#2905

@viambot viambot added the safe to build This pull request is marked safe to build from a trusted zone label Sep 19, 2023
@viambot
Copy link
Member

viambot commented Sep 19, 2023

Overall readability score: 54.45 (🟢 +0)

File Readability
encoded-motor.md 11.86 (🟢 +0)
View detailed metrics

🟢 - Shows an increase in readability
🔴 - Shows a decrease in readability

File Readability FRE GF ARI CLI DCRS
encoded-motor.md 11.86 9.9 19 22 15.1 9.53
  🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0

Averages:

  Readability FRE GF ARI CLI DCRS
Average 54.45 45.92 10.86 13.36 11.9 7.78
  🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0
View metric targets
Metric Range Ideal score
Flesch Reading Ease 100 (very easy read) to 0 (extremely difficult read) 60
Gunning Fog 6 (very easy read) to 17 (extremely difficult read) 8 or less
Auto. Read. Index 6 (very easy read) to 14 (extremely difficult read) 8 or less
Coleman Liau Index 6 (very easy read) to 17 (extremely difficult read) 8 or less
Dale-Chall Readability 4.9 (very easy read) to 9.9 (extremely difficult read) 6.9 or less

Copy link
Contributor

@andf-viam andf-viam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching!

@viambot
Copy link
Member

viambot commented Sep 20, 2023

You can view a rendered version of the docs from this PR at https://docs-test.viam.dev/d9ca6d6cbf330c948d848fbd5ae68ab3c37ccc01/public

@JessamyT JessamyT merged commit 72a134c into main Sep 20, 2023
8 checks passed
@JessamyT JessamyT deleted the JessamyT-patch-1 branch September 20, 2023 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
safe to build This pull request is marked safe to build from a trusted zone
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants