Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve formatting for python script #2109

Merged
merged 2 commits into from
Oct 27, 2023

Conversation

npentrel
Copy link
Collaborator

No description provided.

@viambot viambot added the safe to build This pull request is marked safe to build from a trusted zone label Oct 27, 2023
@npentrel npentrel force-pushed the naomi-improve-formatting branch 3 times, most recently from d2ca84f to 6a190b1 Compare October 27, 2023 14:38
@npentrel npentrel requested a review from sguequierre October 27, 2023 14:38
@npentrel npentrel force-pushed the naomi-improve-formatting branch from 6a190b1 to 8a05b88 Compare October 27, 2023 14:42
"input", "movement_sensor", "power_sensor", "sensor"]
components = ["input"]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
components = ["input"]

Was this just for testing?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep

# Descriptions
description = tag.find("dd")
if description:
for elem in description.find_all("p", recursive=False):
method_text.append(elem.text + "\n")
method_text.append(html_to_markdown(url, elem) + "\n")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@npentrel npentrel merged commit 523579f into viamrobotics:main Oct 27, 2023
10 checks passed
@npentrel npentrel deleted the naomi-improve-formatting branch October 27, 2023 15:05
@viambot
Copy link
Member

viambot commented Oct 27, 2023

You can view a rendered version of the docs from this PR at https://docs-test.viam.dev/2109/public

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
safe to build This pull request is marked safe to build from a trusted zone
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants