-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update registry upload with new cli behavior #2280
Conversation
Overall readability score: 57.25 (🟢 +0)
View detailed metrics🟢 - Shows an increase in readability
Averages:
View metric targets
|
To match viamrobotics/docs#2280, removing `org-id` from GH action yaml.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, added a small formatting / link change.
Do we also need this change: viamrobotics/upload-module#6 ?
Thanks for this!!
Co-authored-by: andf-viam <[email protected]>
You can view a rendered version of the docs from this PR at https://docs-test.viam.dev/2280 |
Co-authored-by: andf-viam <[email protected]>
Description
This page contained some references to the now-removed behavior regarding names & requirements for specifying an org-id.
Now all modules use a
module_id
field in theirmeta.json
so the action does not need theorg_id
and thename
field does not exist anymoreThe action PR: https://github.com/viamrobotics/upload-module/pull/5/files