-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOCS-1604: Document Missing Navigation and SLAM methods #2397
DOCS-1604: Document Missing Navigation and SLAM methods #2397
Conversation
Overall readability score: 55.83 (🔴 -0.02)
View detailed metrics🟢 - Shows an increase in readability
Averages:
View metric targets
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job! Left a couple tiny comments and have the same question about the Go navigation service properties
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM if links fixed!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Great job, all comments are nitpicks/optional so feel free ignore if you prefer the original!
You can view a rendered version of the docs from this PR at https://docs-test.viam.dev/2397 |
Specifically documenting GetPosition (get_position in Python and Position in Go)