DOCS-1865: Address customer feedback #2587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viambot
added
the
safe to build
|
Overall readability score: 55.43 (🟢 +0)
View detailed metrics🟢 - Shows an increase in readability
Averages:
View metric targets
|
JessamyT
reviewed
Feb 27, 2024
JessamyT
reviewed
Feb 27, 2024
Co-authored-by: JessamyT <[email protected]>
Co-authored-by: JessamyT <[email protected]>
JessamyT
approved these changes
Feb 27, 2024
docs/ml/_index.md
Outdated
| </td> | ||
| </tr> | ||
| <tr> | ||
| <td>{{<imgproc src="ml/deploy.svg" class="fill alignright" style="max-width: 300px" declaredimensions=true alt="Deploy your model">}} | ||
| <b>6. Test your detector or classifier</b> | ||
| <p>Test your <a href="/ml/vision/mlmodel/#test-your-detector-or-classifier">mlmodel detector or classifier</a>.</p> | ||
| <p>Follow the <a href="/ml/vision/mlmodel/#test-your-detector-or-classifier">instructions to test your mlmodel detector or classifier</a>.</p> |
There was a problem hiding this comment.
Suggested change
| <p>Follow the <a href="/ml/vision/mlmodel/#test-your-detector-or-classifier">instructions to test your mlmodel detector or classifier</a>.</p> | |
| <p>Follow the <a href="/ml/vision/mlmodel/#test-your-detector-or-classifier">instructions to test your ML model detector or classifier</a>.</p> |
There was a problem hiding this comment.
I think it's already very confusing for it to be named the same I'll hangen it to the code version
There was a problem hiding this comment.
Out-of-diff nits:
- Consider sentence casing the heading of step 3
- Consider adding the word "model" to "machine learning (ML) service" in the first sentence (i.e. change it to "machine learning (ML) model service" for consistency with the rest of the doc
There was a problem hiding this comment.
Isn't it already sentence case?
There was a problem hiding this comment.
Oh you mean number 2
Co-authored-by: JessamyT <[email protected]>
Co-authored-by: JessamyT <[email protected]>
Co-authored-by: JessamyT <[email protected]>
Co-authored-by: JessamyT <[email protected]>
npentrel
commented
Feb 27, 2024
|
You can view a rendered version of the docs from this PR at https://docs-test.viam.dev/2587 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.